0.4 - Java 25, Complex OS Rules, Log Cache Misses, and Java Provisioner 2.0 #6
Conversation
Jonathing
changed the title
|
This is ready for re-review. |
| return null; | ||
| } | ||
| ret = downloaded.home(); | ||
| ret = disco.provision(version).home(); // Implementation detail, we only download jdks, so no need to check here |
There was a problem hiding this comment.
As long as this logs the details for the failed attempts, but doesn't log on success this is fine.
There was a problem hiding this comment.
It does not log on success, yes. This PR also fixes a few other issues with cache misses causing the full log to be released every sync.
|
Nothing is jumping out at me as wrong, so as long as it works for got it. |
The idea was to make some sort of "global class" with a name that makes sense. |
|
I am merging this immediately. I unfortunately haven't been able to test with my two MacBooks at home. If there are issues with Macs still, I'll fix them in a patch. |
Jonathing
force-pushed
the
feat/jonathing/0.4/java-provisioner-2.0
branch
from
bd95018 to
5cc3605
Compare
2 participants
Depends on:
Please don't squash and merge through GitHub.com. I'll merge this myself with the proper tag(s) once approval has been granted.